[Webkit-unassigned] [Bug 125502] [EFL][JSC] Enable udis86 disassembler on efl

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125502





--- Comment #8 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2013-12-11 07:19:54 PST ---
(In reply to comment #3)
> (From update of attachment 218866 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218866&action=review
> 
> r=me, but change the (unsigned long long) casts to (uint64_t) casts.
> 
> > Source/JavaScriptCore/disassembler/udis86/udis86_syn-att.c:130
> > +				mkasm(u, "0x" FMT64 "x", (unsigned long long)(u->pc + op->lval.sbyte)); 
> 
> Please make these casts to uint64_t

It seems that uint64_t is defined as unsigned long int, while FMT64 is "%ll", and this causes the error. At first it seems to be an inconsistency between the 64bit type definitions, but I'll check it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.