[Webkit-unassigned] [Bug 125525] [ATK] Add new layout test to check ATK roles in a central place

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 10 18:03:06 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125525





--- Comment #3 from Mario Sanchez Prada <mario at webkit.org>  2013-12-10 18:01:18 PST ---
(In reply to comment #2)
> (From update of attachment 218887 [details])
> is it possible to use the same Mac test, but with different expectations? it'd > be nice to only modify one test and generate new expectations

Yes, that was my first approach, but I don't think it's possible to reuse the Mac test just by providing new expectations mainly because the accessibility hierarchy is not equivalent (e.g. ATK might not expose elements exposed for Mac, and viceversa), so the list of elements that you might want to skip/check will differ in several cases.

Also, there's the additional problem of this test checking subroles and role descriptions too, which are concepts that do not exist in ATK. So, we would either have to provide a lot of FAIL expectations for ATK or we would need to heavily change the javascript to better work in both platforms, maybe by removing all those data-* attributes for the expectations and using debug() all around. 

But again, even if that might work for some cases, I think in some others it will be more messy than beneficial, as the current approach of using data-* seems quite neat to me.

So, all in all, I thought this would be the least bad solution, even though I agree it's not ideal.

What do you think?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list