[Webkit-unassigned] [Bug 125514] New: PrettyPatch.rb should be more descriptive for "git diff -M" styled patches
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 10 07:21:58 PST 2013
https://bugs.webkit.org/show_bug.cgi?id=125514
Summary: PrettyPatch.rb should be more descriptive for "git
diff -M" styled patches
Product: WebKit
Version: 528+ (Nightly build)
Platform: Unspecified
OS/Version: Unspecified
Status: NEW
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: ossy at webkit.org
CC: darin at apple.com
here is an example:
https://bugs.webkit.org/attachment.cgi?id=218793
https://bugs.webkit.org/attachment.cgi?id=218793&action=review
----------------------------------------------------------------------------
diff --git a/Source/WebKit2/Shared/mac/CertificateInfo.mm b/Source/WebCore/platform/network/mac/CertificateInfoMac.mm
similarity index 75%
rename from Source/WebKit2/Shared/mac/CertificateInfo.mm
rename to Source/WebCore/platform/network/mac/CertificateInfoMac.mm
...
----------------------------------------------------------------------------
Source/WebKit2/Shared/mac/CertificateInfo.mm was moved to Source/WebCore/platform/network/mac/CertificateInfoMac.mm
and then some lines changed, but the pretty diff shows if you changed only Source/WebCore/platform/network/mac/CertificateInfoMac.mm.
In this case it would be better to show exactly the diff header:
rename from Source/WebKit2/Shared/mac/CertificateInfo.mm
rename to Source/WebCore/platform/network/mac/CertificateInfoMac.mm
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list