[Webkit-unassigned] [Bug 100275] Programmatically-inserted children lack accessibility events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=100275


Mario Sanchez Prada <mario at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #218683|0                           |1
        is obsolete|                            |
 Attachment #218683|review?                     |
               Flag|                            |
 Attachment #218843|                            |review?
               Flag|                            |




--- Comment #22 from Mario Sanchez Prada <mario at webkit.org>  2013-12-10 01:30:50 PST ---
Created an attachment (id=218843)
 --> (https://bugs.webkit.org/attachment.cgi?id=218843&action=review)
Patch proposal

(In reply to comment #21)
> [...]
> > By calling
> >  obj->parentObjectUnignored();
> > you still may end up calling accessibilityIsIgnored(). Since this is happening in attachWrapper,
> > it seems OK because I don't think we create AX objects until they're requested (but i could be wrong)
> >
> 
> That's right, and so the comment is definitely wrong. Perhaps there's no need to restrict it to  accessibilityPlatformIncludesObject() and I can just use accessibilityIsIgnored() directly since, as you pointed it out, it might get called anyway in parentObjectUnignored. 
> 
> 
> I'll try that and come up with a new atch asap. Thanks for the review

I've tested that suggestion and it works fine indeed both in WK1 and WK2 for debug and release builds, so I'm updating the patch to use accessibilityIsIgnoredByDefault() instead.

Again, thanks for pointing that out.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.