[Webkit-unassigned] [Bug 125375] REGRESSION (160152): Selection drag snapshot doesn't appear or has the wrong content

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 9 11:14:01 PST 2013


--- Comment #6 from Brian Burg <burg at cs.washington.edu>  2013-12-09 11:12:14 PST ---
(In reply to comment #5)
> I can reproduce with a nightly on Mavericks, but only on Retina hardware (and running that at 1x, everything works fine). Possible something got broken when deviceScaleFactor≠1?

Okay, that helps a lot. I believe the call to ImageBuffer::create has confused the parameters.

    float deviceScaleFactor = frame.page()->deviceScaleFactor();
    IntRect usedRect(imageRect);

    std::unique_ptr<ImageBuffer> buffer = ImageBuffer::create(usedRect.size(), deviceScaleFactor, ColorSpaceDeviceRGB);

It is passing in the computed deviceRect as well as the deviceScaleFactor. Based on other callsites, this should be passing deviceRect and scaleFactor=1, or logicalRect and scaleFactor, but not both.

Could someone do me a favor and change deviceScaleFactor to 1, and see if this is still an issue for retina devices? I can write a test for scaleFactor ≠ 1, but it will have to be tomorrow as I have a huge deadline in 25 hours.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list