[Webkit-unassigned] [Bug 125366] Add missing ENABLE(DRAG_SUPPORT) guards for DragData and its clients

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 8 11:47:30 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125366





--- Comment #5 from Brian Burg <burg at cs.washington.edu>  2013-12-08 11:45:46 PST ---
Thanks for the look-over. Will upload style-fixed patch.

(In reply to comment #4)
> (From update of attachment 218641 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=218641&action=review
> 
> > Source/WebCore/platform/win/DragDataWin.cpp:255
> > +
> 
> Extra blank line at the end of this file.

Filed with check-webkit-style: https://bugs.webkit.org/show_bug.cgi?id=125424

BTW, are there guidelines for when to add guards to forward declarations of classes? I've seen some of the larger files like Frame, Page, and WebPage do that, but not many other files. Is this coming into vogue, going out of style, or just not widely applied?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list