[Webkit-unassigned] [Bug 125248] Inconsistent ENABLE(DRAG_SUPPORT) guards in DragImage.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125248





--- Comment #2 from Brian Burg <burg at cs.washington.edu>  2013-12-06 10:59:00 PST ---
>From looking at uses of functions, it seems that these are the functions not specific to drag functionality (i.e., used by DragController or guarded drag functionality in Clipboard).

DragImageRef createDragImageFromImage(Image*, ImageOrientationDescription);
DragImageRef createDragImageForNode(Frame&, Node&);
DragImageRef createDragImageForSelection(Frame&, bool forceBlackText = false);
DragImageRef createDragImageForRange(Frame&, Range&, bool forceBlackText = false);

So all other functions will be guarded with ENABLE(DRAG_SUPPORT). These tend to coincide with the platform-specific implementations, so the entire DragImageFoo.cpp file can have the guard.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.