[Webkit-unassigned] [Bug 125168] [MIPS] Wrong register usage in LLInt op_catch.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125168





--- Comment #8 from Balazs Kilvady <kilvadyb at homejinni.com>  2013-12-06 09:59:49 PST ---
(In reply to comment #7)
> Patch looks good to me: it solves all remaining crashes in layout jsc tests on my mips board.
> 
> Moreover, it removes the following warnings when compiling the LLINT:
> 
>    [100%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/llint/LowLevelInterpreter.cpp.o
>    /tmp/cc9i3yBA.s: Assembler messages:
>    /tmp/cc9i3yBA.s:270: Warning: No .cprestore pseudo-op used in PIC code
>    /tmp/cc9i3yBA.s:300: Warning: No .cprestore pseudo-op used in PIC code
>    /tmp/cc9i3yBA.s:332: Warning: No .cprestore pseudo-op used in PIC code
>    /tmp/cc9i3yBA.s:375: Warning: No .cprestore pseudo-op used in PIC code
>    [...]
> 
> 
> Although there's a small speed penalty, I think your 2nd patch is better (and more clean).

Thanks for reviewing and testing. The disappearing of the "No .cprestore" warning is a nice side effect as .cprestore is still not used in the LLInt ops. :) But anyway now the generated code seems to be more comfortable to the compiler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.