[Webkit-unassigned] [Bug 123015] [GStreamer] webkitwebaudiosrc element needs to emit stream-start, caps and segment events

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=123015





--- Comment #14 from Martin Robinson <mrobinson at webkit.org>  2013-12-06 01:58:52 PST ---
(From update of attachment 217279)
View in context: https://bugs.webkit.org/attachment.cgi?id=217279&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:408
> +            GRefPtr<GstElement> queue = gst_pad_get_parent_element(pad);

>From http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/GstPad.html, it appears this method returns a fresh reference, so it seems this should be adoptGRef.

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:409
> +            GRefPtr<GstPad> sinkPad = gst_element_get_static_pad(queue.get(), "sink");

Ditto.

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:412
> +            GstEvent* event = gst_event_new_stream_start(streamId.get());

Maybe call this streamStartEvent, just for clarity?

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:422
> +            GRefPtr<GstCaps> caps = adoptGRef(gst_audio_info_to_caps(&info));

capsWithChannelPosition?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.