[Webkit-unassigned] [Bug 125341] Remove function from style/checkers/cpp.py

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 6 01:56:53 PST 2013


Tamas Gergely <tgergely.u-szeged at partner.samsung.com> changed:

           What    |Removed                     |Added
 Attachment #218579|                            |review?
               Flag|                            |

--- Comment #1 from Tamas Gergely <tgergely.u-szeged at partner.samsung.com>  2013-12-06 01:55:10 PST ---
Created an attachment (id=218579)
 --> (https://bugs.webkit.org/attachment.cgi?id=218579&action=review)
patch removes a function

I have simply split the functionality of process_file_data into two parts: the checker is now created directly in the CppStyleTestBase unit test, while setting the module's global _unit_test_config is done from the constructor of CppChecker.
Although currently it causes no problem, I think that setting the global from the constructor is not a nice nor safe solution. What could be done are:
- move the global into the CppChecker class and propagate its value (through 3 functions) to the only place it is used (the 3 functions are used nowhere else), or
- move all the functions (or almost all) into the CppChecker class, or
- leave it as it is now.
By the way, to set up some specific environments, the cpp_unittest uses both globals and parameter propagation. Is one of them preferred?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list