[Webkit-unassigned] [Bug 125329] New: Define m_hasBadParent in InlineBox if defined(ADDRESS_SANITIZER)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 5 19:15:03 PST 2013


https://bugs.webkit.org/show_bug.cgi?id=125329

           Summary: Define m_hasBadParent in InlineBox if
                    defined(ADDRESS_SANITIZER)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ayao at apple.com


Source/WebCore/rendering/InlineBox.{h,cpp} have the concept of m_hasBadParent which is used to detect use after free issues.  It's only enabled #if !ASSERT_DISABLED.

If we're running fuzzing with Address Sanitizer in a release build, we're not getting the benefit of this checking.  It should also be enabled when building with Address Sanitizer.

The simple fix is to convert all the
#if !ASSERT_DISABLED
in these files to
#if !ASSERT_DISABLED || defined(ADDRESS_SANITIZER)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list