[Webkit-unassigned] [Bug 124147] Report error when #else is used in message receiver generator's input.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=124147





--- Comment #16 from Csaba Osztrogonác <ossy at webkit.org>  2013-12-05 14:15:59 PST ---
(In reply to comment #15)
> This change breaks the Windows build:
> 
> Running the tests ...
> [4/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_elif erred:
>   Traceback (most recent call last):
>     File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1135, in test_error_at_elif
>       with self.assertRaisesRegexp(Exception, r"ERROR: '#elif.*' is not supported in the \*\.in files"):
>   AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp'
> 
> [5/1455] webkit2.messages_unittest.UnsupportedPrecompilerDirectiveTest.test_error_at_else erred:
>   Traceback (most recent call last):
>     File "/home/buildbot/slave/win-debug-tests/build/Source/WebKit2/Scripts/webkit2/messages_unittest.py", line 1131, in test_error_at_else
>       with self.assertRaisesRegexp(Exception, r"ERROR: '#else.*' is not supported in the \*\.in files"):
>   AttributeError: 'UnsupportedPrecompilerDirectiveTest' object has no attribute 'assertRaisesRegexp'

Thanks for noticing this failure. But I think it isn't a serious problem, because not the build is broken, only two webkitpy unittest fail. And they
fail because the Windows bots have older than 2.7 python. (which was released
~3.5 years before) Additionally it was a WebKit2 patch and there is no WebKit2
on Windows long time ago.

I think we can fix this problem in 3 different way:
- install newer python to Windows buildbots
- disable this WebKit2 unittest, because there is no WebKit2 on Windows
- use similar workaround to Tools/Scripts/webkitpy/common/webkitunittest.py

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.