[Webkit-unassigned] [Bug 125215] Avoid to add zero offset in BaseIndex.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125215





--- Comment #5 from László Langó <lango at inf.u-szeged.hu>  2013-12-05 01:08:57 PST ---
(In reply to comment #4)
> As a general rule, I would avoid making such changes.  This change has no upside.  The C compiler would have folded the zero, and it would have done it as part of one of many already-mandatory folding passes - even at -O0.  So, you're just duplicating that functionality in offlineasm, which just means more code to maintain and more places where someone might make a mistake.

Thanks for the reply. Yes, you are partly right. The GCC with -O0 really optimize this out, but the clang isn't. It won't do it with -O0. The other reason why I made this is that there's already a similar change in class Address in this file:
http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/offlineasm/cloop.rb#L195

So we should keep or remove from both places. I'm still think this is a good change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.