[Webkit-unassigned] [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 13:46:11 PST 2013


--- Comment #58 from Brian Burg <burg at cs.washington.edu>  2013-12-04 13:44:29 PST ---
(In reply to comment #57)
> > > Source/WebCore/platform/DragImage.cpp:178
> > > +    RenderObject* startRenderer = start.deprecatedNode()->renderer();
> > > +    RenderObject* endRenderer = end.deprecatedNode()->renderer();
> > 
> > I don’t think it’s right for this function to be using deprecatedNode at all. That needs to be fixed.
> OK. I didn't write this code, so I'm unfamiliar with Position or how to handle deprecatedNode. What are the correct replacements? Is there a better approach to accomplishing what this function does?

Looking deeper, I think this should be left alone. Refactoring it without also refactoring FrameSelection::setSelection (i.e., what it's emulating) is just going to lead to unexpected differences and test failures. And I have no desire to learn (god forbid, touch) that part of layout to land snapshot functionality for the inspector.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list