[Webkit-unassigned] [Bug 125126] New: Web Inspector: save view state when reloading main resources without provisional loads

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125126

           Summary: Web Inspector: save view state when reloading main
                    resources without provisional loads
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: burg at cs.washington.edu
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com, graouts at apple.com


The code to restore inspector view state on page reload (in https://webkit.org/b/122125/) saves view state on the Frame.Event.ProvisionalLoadCommitted event, and then tries to restore it on Frame.Event.MainResourceDidChange. However, these events are not one-to-one for things that do not generate provisional loads.

Instead, we should add a symmetric MainResourceWillChange event that is 1:1 with MainResourceDidChange. It needs to be called from Frame.commitProvisionalLoad() and Frame.initialize() when Frame._mainResource is being set. The order should be:

MainResourceWillChange -> (maybe) ProvisionalLoadCommitted -> MainResourceDidChange.

Then, the view state serialization should happen on the first event.

NB. Code in FrameResourceManager.frameDidNavigate is responsible for deciding whether there is a provisional load or not.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.