[Webkit-unassigned] [Bug 125014] Fix broken build when DFG_ENABLE_DEBUG_VERBOSE enabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125014





--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2013-12-02 07:04:12 PST ---
(In reply to comment #3)
> Thanks for the feedback. I see two alternatives but both of them change the existing behavior:
> 
> 1) remove the #define DFG_ENABLE_DEBUG_VERBOSE definition and refactor all dependent conditional code to check the verboseCompilation flag instead of DEBUG_VERBOSE
> 
> or
> 
> 2) remove the #define DFG_ENABLE_DEBUG_VERBOSE definition and remove all dependent conditional code

I already landed this. 

> 
> In the first case this patch is still needed, and there will be a bunch of new messages logged when verboseCompilation enabled. In the second case we loose existing log messages.

There are very few useful messages that were lost. The ones that are lost likely to help when debugging the compiler are available through runtime flags:

--verboseCompilation=true
--showDFGDisassembly=true
--dumpGraphAtEachPhase=true
--dumpBytecodeAtDFGTime=true
--verboseCFA=true

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.