[Webkit-unassigned] [Bug 125048] New: Web Inspector: Use JSHint to check Inspector JS for code style problems

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125048

           Summary: Web Inspector: Use JSHint to check Inspector JS for
                    code style problems
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: burg at cs.washington.edu
                CC: timothy at apple.com, joepeck at webkit.org,
                    webkit-bug-importer at group.apple.com, graouts at apple.com


It looks like it would be not much work to hook up something like JSHint to the check-webkit-style JS checker.

JSHint (jshint.com) is an MIT-licensed fork of JSLint and fairly configurable. We'd want to write a custom reporter that discards things we don't care about. This can be done incrementally- first ignore everything except trailing whitespace, then report more errors as desired.

Steps to minimum viable improvement (checking trailing whitespaces via JSHint):

0. Add a single-file jshint dist to the repository (somewhere?) and add a LICENSE file (license is stated here: http://jshint.com/hack/)

1. Teach the JavaScript checker to invoke JSHint CLI using a built standalone JSC. (http://www.jshint.com/docs/cli/)

2. Create a configuration file (http://www.jshint.com/docs/) that sets some options and defines Web Inspector-specific globals defined in Main.js and Utilities.js.

3. Create a custom reporter and teach the python checker how to interpret the output.

4. Scope the checker to only run for WebInspectorUI sources. Maybe folks want to check non-inspector JS (i.e., tests) as well, but that's out of scope.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.