[Webkit-unassigned] [Bug 29241] focus is not automatically blured after element hide

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=29241





--- Comment #11 from Arunprasad Rajkumar <arurajku at cisco.com>  2013-08-31 09:29:41 PST ---
(In reply to comment #9)
> (In reply to comment #7)
> > Initially I felt Document::cancelFocusAppearanceUpdate() was the right place
> 
> I don’t think that is the right place, and I am not sure why you do.
> 
> > > This should go in the right place, not just a place that happens to work. We should think about exactly what can affect isFocusable and put this in the one or more bottleneck functions that cover all of those things, but not set up the timer if if there is no focused element or no actual change.
> > Definitely. As mentioned earlier, I will try to call Document::cancelFocusAppearanceUpdate() for "visibility:hidden" also.
> 
> This new logic needs to run any time we possibly changed what isFocusable will return for the focused element.
> 
> I’m don’t think that cancelFocusAppearanceUpdate needs to be called in those same places, though. We don’t just want to cancel that timer because something might have changed. I don’t think you’re on the right track here.

Without seeing your comment I uploaded a patch. I will upload a new patch which meets those scenarios.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.