[Webkit-unassigned] [Bug 117008] [WK2][GTK] add support for subtitles on webkit2GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117008





--- Comment #37 from Danilo Cesar Lemes de Paula <danilo.cesar at collabora.co.uk>  2013-08-30 14:17:22 PST ---
(In reply to comment #35)
> (From update of attachment 209902 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209902&action=review
> 
> > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:793
> > -    return String::fromUTF8(C_("Subtitles", "Menu section heading for subtitles"));
> > +    return String::fromUTF8(_("Subtitles"));
> 
> I think you should keep the context string, just put it in the proper place (first argument).
> 
> > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:798
> > -    return String::fromUTF8(C_("Off", "Menu item label for the track that represents disabling closed captions"));
> > +    return String::fromUTF8(_("Off"));
> 
> ditto.
> 
> > Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:803
> > -    return String::fromUTF8(C_("No label", "Menu item label for a closed captions track that has no other name"));
> > +    return String::fromUTF8(_("No label"));
> 
> ditto.


Thanks for the comments kov...
Fixed all those things...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.