[Webkit-unassigned] [Bug 120476] [CSS Masking] Implement luminance masking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120476





--- Comment #2 from Darin Adler <darin at apple.com>  2013-08-30 09:20:12 PST ---
(From update of attachment 210071)
View in context: https://bugs.webkit.org/attachment.cgi?id=210071&action=review

> Source/WebCore/platform/graphics/Image.h:191
> +    bool isLuminanceMask() const { return m_isLuminanceMask; }
> +    void setIsLuminanceMask() { m_isLuminanceMask = true; }

This seems like a strange layer to add this concept at. All images have such a flag? The point of this class is an abstraction for an image. We shouldn’t be building in magic images into the platform layer. The platform layer can provide a new drawing function, but the actual logic for triggering it needs to be up at the filter/SVG level of the call.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.