[Webkit-unassigned] [Bug 120516] Resolve unused parameter warning in FindController.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 08:00:50 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=120516


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #210079|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-08-30 08:00:12 PST ---
(From update of attachment 210079)
View in context: https://bugs.webkit.org/attachment.cgi?id=210079&action=review

> Source/WebKit2/WebProcess/WebPage/FindController.cpp:397
> +void FindController::drawRect(PageOverlay* /*pageOverlay*/, GraphicsContext& graphicsContext, const IntRect& dirtyRect)

Should remove the argument name entirely. There is no information conveyed by a commented-out name that repeats the type.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list