[Webkit-unassigned] [Bug 72584] Support Image Level 3's image() notation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 06:28:08 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=72584





--- Comment #33 from WebKit Commit Bot <commit-queue at webkit.org>  2013-08-30 06:27:28 PST ---
Attachment 210097 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/fast/css/getComputedStyle/computed-style-image-expected.txt', u'LayoutTests/fast/css/getComputedStyle/computed-style-image.html', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/css/CSSImageFallbackValue.cpp', u'Source/WebCore/css/CSSImageFallbackValue.h', u'Source/WebCore/css/CSSImageGeneratorValue.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSParser.h', u'Source/WebCore/css/CSSValue.cpp', u'Source/WebCore/css/CSSValue.h']" exit_code: 1
Source/WebCore/css/CSSValue.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/CSSImageFallbackValue.h:23:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/css/CSSImageFallbackValue.h:54:  The parameter name "color" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/css/CSSImageFallbackValue.h:57:  The parameter name "cachedImage" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list