[Webkit-unassigned] [Bug 120456] [AX][ATK] Added support for sort and help attributes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120456





--- Comment #7 from Krzysztof Czech <k.czech at samsung.com>  2013-08-30 01:23:17 PST ---
> > Source/WebCore/ChangeLog:11
> > +              accessibility/aria-help.html
> 
> the change log says aria-help is added, but i don't see it in this patch
Yes right, I did not catch this.
> 
> > Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:54
> > +    return attributeString == "AXSortDirection" ? "aria-sort" : String();
> 
> since it seems like you'll continue adding to this method you should probably add sort direction to the other list of if statements directly above, and then leave the return "" as the final line
Yes, it seems other attributes will be added. Sounds good.
> 
> > Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:58
> > +    return attributeString == "AXSortDirection" ? "aria-sort" : String();
> 
> ditto with comment from DRT
Sounds good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.