[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103771





--- Comment #144 from WebKit Commit Bot <commit-queue at webkit.org>  2013-08-29 13:39:07 PST ---
Attachment 210023 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/media/content/counting-subtitled-kate.ogv', u'LayoutTests/media/content/counting-subtitled-srt.mkv', u'LayoutTests/media/track/in-band/test-attribute.js', u'LayoutTests/media/track/in-band/test-cues-added-once.js', u'LayoutTests/media/track/in-band/test-mode.js', u'LayoutTests/media/track/in-band/test-style.js', u'LayoutTests/media/track/in-band/test-track-order.js', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-cues-added-once.html', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-kind-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-kind.html', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-language-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-language.html', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-mode-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-mode.html', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-style-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-style.html', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-kate-ogg-track-order.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-cues-added-once.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-kind-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-kind.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-language-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-language.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-mode-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-mode.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-style-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-style.html', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt', u'LayoutTests/media/track/in-band/track-in-band-srt-mkv-track-order.html', u'LayoutTests/platform/mac/TestExpectations', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/PlatformEfl.cmake', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/track/InbandGenericTextTrack.cpp', u'Source/WebCore/html/track/InbandGenericTextTrack.h', u'Source/WebCore/html/track/InbandTextTrack.cpp', u'Source/WebCore/html/track/InbandTextTrack.h', u'Source/WebCore/html/track/InbandWebVTTTextTrack.cpp', u'Source/WebCore/html/track/InbandWebVTTTextTrack.h', u'Source/WebCore/platform/graphics/InbandTextTrackPrivate.h', u'Source/WebCore/platform/graphics/InbandTextTrackPrivateClient.h', u'Source/WebCore/platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp', u'Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/GRefPtrGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h', u'Source/WebCore/platform/graphics/gstreamer/GStreamerVersioning.h', u'Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.h', u'Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp', u'Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.h']" exit_code: 1
Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:48:  webkit_text_combiner_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:187:  webkit_text_combiner_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:45:  webkit_text_sink_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebCore/platform/graphics/gstreamer/TextSinkGStreamer.cpp:79:  webkit_text_sink_class_init is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 4 in 59 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.