[Webkit-unassigned] [Bug 119938] Animate CSS Image filter() function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 29 11:17:44 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119938





--- Comment #27 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-08-29 11:17:05 PST ---
(From update of attachment 209973)
View in context: https://bugs.webkit.org/attachment.cgi?id=209973&action=review

You should add a test for animations between -webkit-filter(url(foo), ...) and url(foo), which should animate the filter values to the no-op filter (just like the filter property).

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:903
> +static inline PassRefPtr<CSSPrimitiveValue> adjustLengthForZoom(double length, const RenderStyle* style, AdjustPixelVaulesForZoom adjust)

AdjustPixelVaulesForZoom is mis-spelled. It's also weird to have the same name for the enum as one of its values.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:919
> +    for (const ShadowData* s = shadow; s; s = s->next()) {

We don't use short variable names like 's'. Maybe currShadowData?

> Source/WebCore/css/CSSComputedStyleDeclaration.h:51
> +enum AdjustPixelVaulesForZoom { AdjustPixelValuesForZoom, DoNotAdjustPixelValues };

Spelling.

> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:221
> +    blendFilterOperations(anim, filterOperationsResult,
> +        fromValue->filterOperations(), toValue->filterOperations(), progress);

I don't think you need to wrap these lines.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list