[Webkit-unassigned] [Bug 103771] [GStreamer] support in-band text tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=103771





--- Comment #137 from Brendan Long <b.long at cablelabs.com>  2013-08-29 09:18:28 PST ---
Would it be bad if I made InbandTextTrackPrivate::cueFormat() a pure virtual function and removed InbandTextTrackPrivate::create()?

Every subclass should pick a CueFormat, and it would be convenient if we could be assured of that at compile-time, but nothing else in that class is pure-virtual, and the existence of the create() function confuses me.

A grep shows that it's not used though:

$ grep -r InbandTextTrackPrivate::create Source
# nothing

Another option would be to make InbandTextTrackPrivate::cueFormat() default to Generic.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.