[Webkit-unassigned] [Bug 120456] [AX][ATK] Added support for sort and help attributes.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 29 09:04:22 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=120456





--- Comment #5 from chris fleizach <cfleizach at apple.com>  2013-08-29 09:03:44 PST ---
(From update of attachment 209961)
View in context: https://bugs.webkit.org/attachment.cgi?id=209961&action=review

> Source/WebCore/ChangeLog:11
> +              accessibility/aria-help.html

the change log says aria-help is added, but i don't see it in this patch

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:54
> +    return attributeString == "AXSortDirection" ? "aria-sort" : String();

since it seems like you'll continue adding to this method you should probably add sort direction to the other list of if statements directly above, and then leave the return "" as the final line

> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:58
> +    return attributeString == "AXSortDirection" ? "aria-sort" : String();

ditto with comment from DRT

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list