[Webkit-unassigned] [Bug 119135] [CSS Regions] Anonymous nested regions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 09:44:34 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119135





--- Comment #11 from Darin Adler <darin at apple.com>  2013-08-28 09:43:57 PST ---
(From update of attachment 209858)
View in context: https://bugs.webkit.org/attachment.cgi?id=209858&action=review

> Source/WebCore/rendering/RenderObject.h:645
> +    Node* generatingNode() const
> +    {
> +        if (isRenderRegion() && parent())
> +            return parent()->node();
> +        return isPseudoElement() ? generatingPseudoHostElement() : node();
> +    }

Can this return Element*, or could it actually be a non-Element node in some case?

This function is getting kind of long. Does it really need to be inlined? If it does, can we at least put it outside the class definition?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list