[Webkit-unassigned] [Bug 120322] AX: Cancel button in search field not accessible.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 27 15:52:25 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=120322





--- Comment #14 from Samuel White <samuel_white at apple.com>  2013-08-27 15:51:48 PST ---
(In reply to comment #10)
> (From update of attachment 209796 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209796&action=review
> 
> > Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:69
> > +    if (!m_renderer || !m_renderer->style() || m_renderer->style()->visibility() != VISIBLE)
> 
> i think this (visibility check) is already handled by
> accessibilityIsIgnoredByDefault(), which calls defaultObjectInclusion(), which has the appropriate check in AXRenderObject

Good catch, thanks.

> 
> > LayoutTests/platform/mac/accessibility/search-field-cancel-button.html:21
> > +        accessibilityController.accessibleElementById("search").childAtIndex(1).press();
> 
> you should also output the role and role description for this object as part of your test
> 

Added.

> > LayoutTests/platform/mac/accessibility/search-field-cancel-button.html:25
> > +    }
> 
> i think you're missing a succesfullyParsed = true; call at the bottom. that should be present in other tests

This is handled in the post script that runs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list