[Webkit-unassigned] [Bug 120322] AX: Cancel button in search field not accessible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120322





--- Comment #10 from chris fleizach <cfleizach at apple.com>  2013-08-27 14:33:42 PST ---
(From update of attachment 209796)
View in context: https://bugs.webkit.org/attachment.cgi?id=209796&action=review

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:69
> +    if (!m_renderer || !m_renderer->style() || m_renderer->style()->visibility() != VISIBLE)

i think this (visibility check) is already handled by
accessibilityIsIgnoredByDefault(), which calls defaultObjectInclusion(), which has the appropriate check in AXRenderObject

> LayoutTests/platform/mac/accessibility/search-field-cancel-button.html:21
> +        accessibilityController.accessibleElementById("search").childAtIndex(1).press();

you should also output the role and role description for this object as part of your test

> LayoutTests/platform/mac/accessibility/search-field-cancel-button.html:25
> +    }

i think you're missing a succesfullyParsed = true; call at the bottom. that should be present in other tests

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.