[Webkit-unassigned] [Bug 118553] Hash navigation doesn't affect history when the page is retrieved from appcache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118553





--- Comment #9 from Zoltan Herczeg <zherczeg at webkit.org>  2013-08-27 11:27:13 PST ---
> One further thought. Since the only caller is setting this at construction time, would be nice to just set this in the constructor, leave out setShouldRevealToSessionHistory entirely, and maybe even make m_shouldRevealToSessionHistory const.

I was thinking about that myself, but passing a "true" there does not really say anything what is happening (there was a long discussion about passing true/false arguments), and I try to avoid it. So my question is, what would you prefer: passing a true, or passing an enum (which could be converted to a boolean inside the constructor) or passing a const value (defining a kSomething = true inside the class) or leave the code as it is now?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.