[Webkit-unassigned] [Bug 119883] [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119883





--- Comment #17 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-08-27 08:32:38 PST ---
(From update of attachment 209474)
View in context: https://bugs.webkit.org/attachment.cgi?id=209474&action=review

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:119
>> +    if (notificationName.length())
> 
> need brackets for this if and then for, because contents in the middle are longer than a line

Ok, I'll add them.

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:121
>> +            if ((it->key == accessible) || (it->key == GlobalNotificationKey)) {
> 
> these params around each term is not necessary

Ok, I'll remove them.

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:234
>> +    for (HashMap<PlatformUIElement, AccessibilityNotificationHandler*>::iterator it = notificationHandlers.begin(); it != notificationHandlers.end(); ++it)
> 
> we need brackets for this for loop because the contents are more than one line

Ok.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:39
>> +    JSObjectRef m_notificationFunctionCallback;
> 
> this seems like it should be a RefPtr or something that retains this function

I have tried to find a way to make it RefPtr but it didn't go well. JSObjectRef has a forward declaration from OpaqueJSValue, and RefPtr requires the type definition beforehand.
I have also searched for other places where JSObjectRef is used, and unfortunately I couldn't find any reference of how I could implement this. Would you have any recommendation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.