[Webkit-unassigned] [Bug 120322] AX: Cancel button in search field not accessible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120322





--- Comment #3 from chris fleizach <cfleizach at apple.com>  2013-08-26 17:10:49 PST ---
(From update of attachment 209692)
View in context: https://bugs.webkit.org/attachment.cgi?id=209692&action=review

where's the change log?
also you need a layout test
i've submitted to EWS so we'll find out which platforms break by not including the files in their make files

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:52
> +    if (!description.isEmpty())

since you know the description won't be empty (since it's a localized string) you could make this one line of code

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:58
> +    if (!m_renderer || !m_renderer->node() || !m_renderer->node()->isElementNode())

You should be able to ask for
Node* node = this->node()
directly and AXRenderObject should return m_renderer->node() for you

if you cache that value you'll also save a few calls

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:63
> +    element->accessKeyAction(true);

you should probably add a comment explaining why you need to call setHovered

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:69
> +    return ButtonRole;

this can be moved into the header

> Source/WebCore/accessibility/AccessibilitySearchFieldButtons.cpp:74
> +    if (!m_renderer || !m_renderer->style() || m_renderer->style()->visibility() != VISIBLE)

is this the default accessibilityIsIgnored value? is there a baseAccessibilityIsIgnored() that you can call?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.