[Webkit-unassigned] [Bug 118553] Hash navigation doesn't affect history when the page is retrieved from appcache

Mon Aug 26 09:27:54 PDT 2013

https://bugs.webkit.org/show_bug.cgi?id=118553

--- Comment #5 from Brady Eidson <beidson at apple.com>  2013-08-26 09:27:18 PST ---
(From update of attachment 209634)
View in context: https://bugs.webkit.org/attachment.cgi?id=209634&action=review

> LayoutTests/http/tests/appcache/resources/history-back.html:4
> +<html>
> +<body onload="window.history.back()">
> +</body>
> +</html>

Would love to see this use http/tests/navigation/resources/go-back.html instead of adding a new "go-back" page.

> Source/WebCore/loader/SubstituteData.h:55
> +        bool keepInHistory() const { return m_keepInHistory; }
> +        void setKeepInHistory(bool value) { m_keepInHistory = value; }

A few points on naming:
- "keep in history" suggests that this represents something that was added to history, we're considering removing it, but we shouldn't remove it.
That's not quite what is happening.  Reading the users of DocumentLoader::urlForHistory() I think it would be more clear to say "shouldRevealToHistory" or something similar.
- "History" is confusing. We need to continue unraveling the confusion between back/forward history and global browser history.  Please call it "shouldRevealToSessionHistory"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.