[Webkit-unassigned] [Bug 120204] Tighten before/after pseudo element accessors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120204


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209534|review?                     |review+
               Flag|                            |




--- Comment #6 from Andreas Kling <akling at apple.com>  2013-08-24 03:51:28 PST ---
(From update of attachment 209534)
View in context: https://bugs.webkit.org/attachment.cgi?id=209534&action=review

r=me

> Source/WebCore/dom/Element.cpp:2069
> +    if (pseudoElementSpecifier != BEFORE && pseudoElementSpecifier != AFTER)
> +        return 0;
> +    return pseudoElementSpecifier == BEFORE ? host->beforePseudoElement() : host->afterPseudoElement();

This might look better as a switch.

> Source/WebCore/dom/Element.cpp:2310
> +bool Element::updateExistingPseudoElement(PseudoElement* existing, Style::Change change)

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2341
> +    if (PseudoElement* existing = beforePseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2352
> +    if (PseudoElement* existing = afterPseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2396
> +    if (!hasRareData())
> +        return;

This could be an assertion instead, if we moved the two clearFooPseudoElement() calls in clearStyleDerived... after the hasRareData check.

> Source/WebCore/dom/Element.cpp:2404
> +    if (!hasRareData())
> +        return;

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.