[Webkit-unassigned] [Bug 119829] IAccessibleText/2 implementation for AppleWindows port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119829





--- Comment #19 from chris fleizach <cfleizach at apple.com>  2013-08-23 16:10:27 PST ---
(From update of attachment 209523)
View in context: https://bugs.webkit.org/attachment.cgi?id=209523&action=review

> Source/WebKit/win/AccessibleTextImpl.cpp:130
> +    if (m_object->renderer()->document()->frame()->selection().isNone())

You should use m_object->document() and ensure existence of document()

> Source/WebKit/win/AccessibleTextImpl.cpp:235
> +    m_object->renderer()->document()->frame()->selection().clear();

ditto about document()

> Source/WebKit/win/AccessibleTextImpl.cpp:548
> +    ASSERT(m_object->renderer()->document()->frame());

why do you need to assert frame() here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.