[Webkit-unassigned] [Bug 119829] IAccessibleText/2 implementation for AppleWindows port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119829





--- Comment #16 from WebKit Commit Bot <commit-queue at webkit.org>  2013-08-23 16:05:59 PST ---
Attachment 209523 did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj', u'Source/WebKit/WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj', u'Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj.filters', u'Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj', u'Source/WebKit/WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters', u'Source/WebKit/win/AccessibleBase.cpp', u'Source/WebKit/win/AccessibleBase.h', u'Source/WebKit/win/AccessibleTextImpl.cpp', u'Source/WebKit/win/AccessibleTextImpl.h', u'Source/WebKit/win/ChangeLog']" exit_code: 1
Source/WebKit/win/AccessibleTextImpl.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:67:  AccessibleText::get_attributes is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:77:  AccessibleText::get_caretOffset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:91:  AccessibleText::get_characterExtents is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:125:  AccessibleText::get_nSelections is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:137:  AccessibleText::get_offsetAtPoint is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:168:  AccessibleText::get_selection is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:185:  AccessibleText::get_text is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:201:  AccessibleText::get_textBeforeOffset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:209:  AccessibleText::get_textAfterOffset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:217:  AccessibleText::get_textAtOffset is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:268:  AccessibleText::get_nCharacters is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:273:  Tab found; better to use spaces  [whitespace/tab] [1]
Source/WebKit/win/AccessibleTextImpl.cpp:345:  AccessibleText::get_Text is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:353:  AccessibleText::get_oldText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:363:  AccessibleText::get_attributeRange is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.cpp:498:  AccessibleText::get_attributes is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WebKit/win/AccessibleTextImpl.h:45:  The parameter name "boundaryType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/AccessibleTextImpl.h:46:  The parameter name "boundaryType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/AccessibleTextImpl.h:47:  The parameter name "boundaryType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/AccessibleTextImpl.h:49:  The parameter name "offset" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/AccessibleTextImpl.h:52:  The parameter name "scrollType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebKit/win/AccessibleTextImpl.h:53:  The parameter name "coordinateType" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 23 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.