[Webkit-unassigned] [Bug 120226] Use ElementTraversal some more

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120226


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209505|review?                     |review+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2013-08-23 13:35:23 PST ---
(From update of attachment 209505)
View in context: https://bugs.webkit.org/attachment.cgi?id=209505&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1126
> +        const AtomicString& siblingAriaRole = sibling->getAttribute(roleAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLObjectElement.cpp:464
> -    for (Element* child = ElementTraversal::firstWithin(this); child; child = ElementTraversal::nextSibling(child)) {
> +    for (auto child = ElementTraversal::firstChild(this); child; child = ElementTraversal::nextSibling(child)) {

Looks to me like this is a drive-by bug fix. Was something slightly broken?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.