[Webkit-unassigned] [Bug 119063] HistoryController: setting the pageScaleFactor and scrollPoint properly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 23 13:29:03 PDT 2013


https://bugs.webkit.org/show_bug.cgi?id=119063





--- Comment #11 from Thiago de Barros Lacerda <thiago.lacerda at openbossa.org>  2013-08-23 13:28:29 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #5)
> > > > There are not tests for HistoryController, even with the old behaviour.
> > > > Do you think it is worth adding test for that?
> > > 
> > > Is it testable?
> > 
> > I can think now of a simple test, creating a HistoryController instance and 2 HistoryItems, with different scales and scroll points, and play around going back and forward with them. I think it is enough for testing it. What do you think?
> 
> How does that translate to a LayoutTest?

Brady, I couldn't make a LayoutTest on that. But as you can see this patch is very reasonable and we need it in Nix port. Additionally I can't see how it can add any problems to other ports.

Regards

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the webkit-unassigned mailing list