[Webkit-unassigned] [Bug 117008] [WK2][GTK] add support for subtitles on webkit2GTK

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=117008





--- Comment #28 from Martin Robinson <mrobinson at webkit.org>  2013-08-23 12:26:35 PST ---
(From update of attachment 209487)
View in context: https://bugs.webkit.org/attachment.cgi?id=209487&action=review

> Source/WebCore/html/shadow/MediaControlsGtk.cpp:46
> +        return listener->type() == GObjectEventListenerType
> +            ? static_cast<const MediaControlsGtkEventListener*>(listener)
> +            : 0;

This should really be one line.

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:146
> +    prefs->setShouldDisplaySubtitles(TRUE);

TRUE -> true

> LayoutTests/platform/gtk/TestExpectations:793
> +webkit.org/b/101670 media/video-controls-captions-trackmenu.html [ Failure Pass ]
> +webkit.org/b/101670 media/video-controls-captions-trackmenu-sorted.html [ Pass ]
> +webkit.org/b/101670 media/video-controls-captions-trackmenu-localized.html [ Pass ]
> +webkit.org/b/101670 media/video-controls-captions-trackmenu-hide-on-click.html [ Pass ]
> +webkit.org/b/101670 media/video-controls-captions-trackmenu-hide-on-click-outside.html [ Pass ]

I believe that marking them as passing here is like marking them flaky. Are these flaky?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.