[Webkit-unassigned] [Bug 119883] [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119883





--- Comment #15 from chris fleizach <cfleizach at apple.com>  2013-08-23 11:25:05 PST ---
(From update of attachment 209474)
View in context: https://bugs.webkit.org/attachment.cgi?id=209474&action=review

almost there!

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:119
> +    if (notificationName.length())

need brackets for this if and then for, because contents in the middle are longer than a line

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:121
> +            if ((it->key == accessible) || (it->key == GlobalNotificationKey)) {

these params around each term is not necessary

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:234
> +    for (HashMap<PlatformUIElement, AccessibilityNotificationHandler*>::iterator it = notificationHandlers.begin(); it != notificationHandlers.end(); ++it)

we need brackets for this for loop because the contents are more than one line

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:39
> +    JSObjectRef m_notificationFunctionCallback;

this seems like it should be a RefPtr or something that retains this function

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.