[Webkit-unassigned] [Bug 119883] [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119883





--- Comment #13 from Denis Nomiyama (dnomi) <d.nomiyama at samsung.com>  2013-08-23 10:31:07 PST ---
(From update of attachment 209378)
View in context: https://bugs.webkit.org/attachment.cgi?id=209378&action=review

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:118
>> +#if PLATFORM(GTK)
> 
> does this have to be GTK only? we're already in the ATK file

This ATK file is also used by EFL, which doesn't share the same API to get the JS global context.
I can remove #if GTK from other places around AccessibilityNotificationHandler because they won't break the EFL build.
But unfortunately I can't implement this one as I don't have a EFL env to test it. So on EFL the mechanism will be almost ready and only missing the final call to the JS callback.

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:121
>> +            // The global notification handler is stored with key 0.
> 
> can you #define the GlobalNotificationKey so you don't have to comment about key == 0 everywhere

Ok. I will add it.

>> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:232
>> +void removeAccessibilityNotificationHandler(AccessibilityNotificationHandler *notificationHandler)
> 
> * in wrong place

Ops, sorry.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:2
>> + * Copyright (C) 2011 Google Inc. All rights reserved.
> 
> seems like this copyright is erroneous

Ok. I will fix it.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:59
>> +    if (!notificationFunctionCallback)
> 
> seems like if you pass 0 in, it should remove the current function callback, and then return

Good point. I will do it.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:2
>> + * Copyright (C) 2011 Google Inc. All rights reserved.
> 
> seems like this copyright is erroneous

Ok. I will fix it.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:45
>> +    AtkObject* platformElement(void) { return m_platformElement; }
> 
> this should be const

Ok. I will fix it.

>> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:47
>> +    JSObjectRef notificationFunctionCallback(void) { return m_notificationFunctionCallback; }
> 
> ditto about const

Ok

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.