[Webkit-unassigned] [Bug 120168] Fix srcset's image candidate algorithm when DPR exceeds all candidates

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120168


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209439|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Andreas Kling <akling at apple.com>  2013-08-23 09:02:31 PST ---
(From update of attachment 209439)
View in context: https://bugs.webkit.org/attachment.cgi?id=209439&action=review

Looks good!
r=me with a minor style change:

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:370
> +    return imageCandidates[i-1].imageURL;

This would look slightly better as:
    return imageCandidates.last().imageURL;

Then we wouldn't have to keep the loop variable alive.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.