[Webkit-unassigned] [Bug 113849] [Cairo] Marker-mid of svg is not displayed.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=113849





--- Comment #10 from Christophe Dumez <dchris at gmail.com>  2013-08-23 04:00:30 PST ---
(In reply to comment #9)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Attachment 209444 [details] [details] [details] did not pass style-queue:
> > > 
> > > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/efl/svg/custom/circular-marker-reference-2-expected.png', u'LayoutTests/platform/efl/svg/custom/circular-marker-reference-2-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/graphics/cairo/PathCairo.cpp', u'Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp', u'Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h']" exit_code: 1
> > > Source/WebCore/platform/graphics/cairo/PlatformPathCairo.h:165:  Missing spaces around >>  [whitespace/operators] [3]
> > > Source/WebCore/platform/graphics/cairo/PlatformPathCairo.cpp:41:  Missing spaces around >>  [whitespace/operators] [3]
> > > Total errors found: 2 in 7 files
> > > 
> > > 
> > > If any of these errors are false positives, please file a bug against check-webkit-style.
> > 
> > Looks like a style script bug.
> Sorry. I did not read this and uploaded patch again for fixing style error, but I'm not sure it is right.

It is a bug in the style script, it is confused by '>>' which is now allowed in C++11. I wouldn't change anything to make the style script happy. We should file a bug against the style script instead since I believe it was already announced on the mailing list that it was OK not to add the space anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.