[Webkit-unassigned] [Bug 120084] Allow the inspector to show the reason for style invalidation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120084





--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2013-08-23 00:25:34 PST ---
(From update of attachment 209226)
View in context: https://bugs.webkit.org/attachment.cgi?id=209226&action=review

> Source/WebCore/inspector/InspectorInstrumentation.h:191
> +    enum RecalcStyleReason {
> +        NoReason,
> +        CSSAnimation,
> +        Fullscreen,
> +        ActiveState,
> +        HoverState,
> +        FocusState,
> +        AttributeChange,
> +        ClassAttributeChange,
> +        InlineStyleChange,
> +        SelectorSensitiveStateChange,
> +        DOMTreeChange,
> +        FormControlChange,
> +        DragStateChange,
> +    };

It might be useful to make the reason tracking part of the style resolve code rather than being in Inspector land. We might have internal uses for this information. Specifically we might want to decide what sort of resolve to do at resolve time instead at invalidation time like we do now.

This is not really a show stopper for this patch (we can switch over later) but something to consider.

>> Source/WebCore/inspector/InspectorInstrumentation.h:196
>> +    class RecalcStyleReasonSetter {
> 
> Would be nice to make this explicitly non-copyable.

Global variable based hackery like this is pretty distasteful. It is probably ok for Inspector interface but at least we shouldn't propagate these elsewhere.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.