[Webkit-unassigned] [Bug 120119] Add some operator overloads to VisiblePosition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120119


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209410|review?                     |review-
               Flag|                            |




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2013-08-22 17:32:18 PST ---
(From update of attachment 209410)
View in context: https://bugs.webkit.org/attachment.cgi?id=209410&action=review

> Source/WebCore/dom/Position.h:243
> +inline bool operator<(const Position& a, const Position& b)
> +{
> +    return a.anchorNode() == b.anchorNode() && a.deprecatedEditingOffset() < b.deprecatedEditingOffset() && a.anchorType() == b.anchorType();
> +}

I don't think this comparison operator makes sense.  Just because nodes aren't same doesn't mean they aren't comparable.

If anything, we should be calling comparePositions instead. r-.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.