[Webkit-unassigned] [Bug 119883] [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=119883


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #209378|1                           |0
        is obsolete|                            |




--- Comment #10 from chris fleizach <cfleizach at apple.com>  2013-08-22 11:39:35 PST ---
(From update of attachment 209378)
View in context: https://bugs.webkit.org/attachment.cgi?id=209378&action=review

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:118
> +#if PLATFORM(GTK)

does this have to be GTK only? we're already in the ATK file

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:121
> +            // The global notification handler is stored with key 0.

can you #define the GlobalNotificationKey so you don't have to comment about key == 0 everywhere

> Tools/DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:232
> +void removeAccessibilityNotificationHandler(AccessibilityNotificationHandler *notificationHandler)

* in wrong place

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

seems like this copyright is erroneous

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp:59
> +    if (!notificationFunctionCallback)

seems like if you pass 0 in, it should remove the current function callback, and then return

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:2
> + * Copyright (C) 2011 Google Inc. All rights reserved.

seems like this copyright is erroneous

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:45
> +    AtkObject* platformElement(void) { return m_platformElement; }

this should be const

> Tools/DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:47
> +    JSObjectRef notificationFunctionCallback(void) { return m_notificationFunctionCallback; }

ditto about const

> Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:1060
> +#else

you don't really need the #else here at all

but same comment as above, can we just enable this for all ATK

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.