[Webkit-unassigned] [Bug 120069] [MathML] Implement the subscriptshift and superscriptshift attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=120069


Frédéric Wang <fred.wang at free.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cfleizach at apple.com




--- Comment #4 from Frédéric Wang <fred.wang at free.fr>  2013-08-22 05:26:40 PST ---
(In reply to comment #3)
> Hi Frederic. I have done changes related to subscriptshift and superscriptshift attributes but since its dependent on 99619 I cannot submit the patch. I am attaching the .cpp file. Let me know how should I go about now?
> 
> I have also added the attributes in mathattrs.in.

Thanks Gurpreet. Please attach a patch, that's much easier to see your changes and will be needed to ask a review anyway. I'm not sure what your problem is? You can for example commit the patch of bug 99619 in a local branch, then do your changes and finally execute a diff to create your patch. See the doc of svn/git or ask help on irc if you're not familiar with these tools.

Chris is reviewing my patch for mmultiscripts but it's a bit big so it will take some time. Working on the easier bug 118904 as I suggested by email is probably a better way for you to get familiar with the WebKit review process & unit test framework and it won't be blocked by other bugs.

Regarding your patch, the "for" loop is essentially checking all the subscript/superscript pairs (there can be many for mmultiscripts) and computing the maximum for top/bottom paddings. So I don't think incrementing these paddings by superscriptShift/subscriptShift at each step is what you want. Rather, I think the superscriptShift/subscriptShift values can be computed before entering the loop and then used in the computation of minBaseline and minExtendUnderBaseline at each step.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.