[Webkit-unassigned] [Bug 99618] [MathML] Implement the mmultiscripts tag

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=99618





--- Comment #22 from Frédéric Wang <fred.wang at free.fr>  2013-08-22 00:14:29 PST ---
(In reply to comment #21)
> i'm not sure which render tree structure you're saying you're going to use here. Are you using the above version for valid elements, or the below version for valid and invalid elements?

I'm using the below version for valid and invalid elements. In particular that allows to avoid rebuilding everything when children are added/removed and the mmultiscripts becomes temporarily invalid.

> didn't you already hit the prescript tag in the first loop? is there a reason to check for it again?

Per the previous remark, invalid mmultiscripts may have more than one mprescripts, so I'll have to take care of that too.

> > Source/WebCore/rendering/mathml/RenderMathMLScripts.cpp:96
> > +    scriptsStyle->setJustifyContent(m_kind == Sub ? JustifyFlexStart : m_kind == Super ? JustifyFlexEnd : JustifySpaceBetween);
> 
> i don't see anything explicit about non-wrapped comments but these will be easer to read if the comments wrap after a reasonable number of characters

I used 80 columns at some point but you mentioned I should not (that was in a reftest file IIRC). I also seem to remember that the check-webkit-style complained when a comment wraps in a C++ file. I'll check into that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.