[Webkit-unassigned] [Bug 97229] Spatial navigation is not working for anchor with inline div with inline img

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=97229





--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com>  2013-08-21 10:46:54 PST ---
(From update of attachment 209285)
View in context: https://bugs.webkit.org/attachment.cgi?id=209285&action=review

> Source/WebCore/page/SpatialNavigation.cpp:340
> +    bool blockInsideInline = false;
> +    if (render->isRenderInline()) {
> +        for (Node* curr = node->firstChild(); curr; curr = curr->nextSibling()) {
> +            if (curr->renderer() && curr->renderer()->isRenderBlock()) {
> +                blockInsideInline = true;
> +                break;
> +            }
> +        }
> +    }
> +
> +    LayoutRect rect = blockInsideInline ? node->renderer()->absoluteBoundingBoxRect() : node->boundingBox();
>      if (rect.isEmpty())

It's weird to jump between nodes and renders like this. Can't this code just use absoluteFocusRingQuads or similar?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.